Change type definition for DeployTargetsByPlugin #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
ffjlabo
requested review from
khanhtc1202,
t-kikuc and
Warashi
as code owners
khanhtc1202
previously approved these changes
Feb 7, 2025
t-kikuc
previously approved these changes
Feb 7, 2025
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
khanhtc1202
approved these changes
Feb 7, 2025
t-kikuc
approved these changes
Feb 7, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5555 +/- ##
==========================================
- Coverage 26.44% 26.43% -0.02%
==========================================
Files 465 465
Lines 49862 49901 +39
==========================================
+ Hits 13188 13189 +1
- Misses 35620 35657 +37
- Partials 1054 1055 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
sd title
Why we need it:
We can't use type
google.protobuf.ListValuebecause Firestore SDK doesn't treat the type.Which issue(s) this PR fixes:
Part of #4980 #5252
Follow #5553 #5554
Does this PR introduce a user-facing change?: